feat: introduce children
function to shorthands
#4029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
children
callback usage in any existing shorthands. This change was originally made for Stardust UI / Fluent UI Northstar (microsoft/fluent-ui-react#1951) which had the more complicated API.In case of Semantic UI React this will a soft migration to avoid any breaking changes: new API is added and the previous API becomes deprecated. It's expected to remove the old one with functions in V3.
💡 Motivation for changes
#1724 is discussing to add more types for options in
Dropdown
, the same issue can be met inMenu
. In Fluent UI Northstar these issues were solved withkind
prop:However, the current implantation with having shorthand as a function blocks it as there is no way to combine
{ kind: 'smth' }
and() => {}
🤔🔧 Actual changes
The API was introduced and docs were added, now if you would like to customize rendered elements please use
children
function on any shorthand:To avoid breaking changes in future releases please modify your existing usages:
The warning was added to inform users about them.
Please share feedback and concerns 👍