Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(theming) update theme.config override example #4174

Merged
merged 3 commits into from Jun 28, 2021

Conversation

the133448
Copy link
Contributor

@the133448 the133448 commented Mar 16, 2021

This matches the format inside node_modules/semantic-ui-less/theme.config.example
fixes #4173

@welcome
Copy link

welcome bot commented Mar 16, 2021

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@the133448 the133448 changed the title Fix #417 Update Theming.mdx Fix #4173 Update Theming.mdx Mar 16, 2021
@the133448 the133448 changed the title Fix #4173 Update Theming.mdx 📝 Update Theming.mdx Mar 16, 2021
@the133448 the133448 changed the title 📝 Update Theming.mdx docs(theming) update theme.config override example Mar 16, 2021
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #4174 (e2b70a4) into master (cc7ec31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4174   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3241     3241           
=======================================
  Hits         3233     3233           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7ec31...e2b70a4. Read the comment docs.

@the133448
Copy link
Contributor Author

Thanks @layershifter , your right! Don't know why I missed that.

@welcome
Copy link

welcome bot commented Jun 28, 2021

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation for theming
3 participants