Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add enterKeyHint to list of htmlInputAttrs #4377

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix(core): add enterKeyHint to list of htmlInputAttrs #4377

merged 1 commit into from
Aug 18, 2022

Conversation

ben-rogerson
Copy link
Contributor

This PR adds the missing enterKeyHint attribute which allows the customisability of the enter key on virtual keyboards.

In my usage, this fixes an issue on Android where the enter button character doesn't reflect the action it performs.

Closes #4371

This PR adds the missing `enterKeyHint` attribute which allows the customisability of the enter key on virtual keyboards.

In my usage, this fixes an issue on Android where the enter button character doesn't reflect the action it performs.

Closes #4371
@welcome
Copy link

welcome bot commented Aug 17, 2022

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

Codecov Report

Merging #4377 (22037cf) into master (134ba34) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4377   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3248     3248           
=======================================
  Hits         3240     3240           
  Misses          8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@layershifter layershifter merged commit 0e1a55a into Semantic-Org:master Aug 18, 2022
@welcome
Copy link

welcome bot commented Aug 18, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@layershifter layershifter changed the title Add enterKeyHint to list of htmlInputAttrs fix(core): add enterKeyHint to list of htmlInputAttrs Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to pass enterkeyhint to an Input
3 participants