Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Portal): fix event handling for mouseEnter/mouseLeave #4445

Merged
merged 2 commits into from Dec 10, 2023

Conversation

tourman
Copy link
Contributor

@tourman tourman commented Nov 28, 2023

Fixing #4442 and other other similar typo.

Copy link

welcome bot commented Nov 28, 2023

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba4b720) 99.51% compared to head (eb03d99) 99.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4445   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         186      186           
  Lines        3511     3511           
=======================================
  Hits         3494     3494           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@layershifter layershifter changed the title 4442 fix(Portal): fix event handling Dec 10, 2023
@layershifter layershifter changed the title fix(Portal): fix event handling fix(Portal): fix event handling for mouseEnter/mouseLeave Dec 10, 2023
@layershifter layershifter merged commit 888b2f7 into Semantic-Org:master Dec 10, 2023
9 of 10 checks passed
Copy link

welcome bot commented Dec 10, 2023

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@dimitur2204
Copy link

@layershifter Is there a date/schedule for the release for this one?

@layershifter
Copy link
Member

Released in 3.0.0-beta.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants