Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] Vendor styled input render too tall #2704

Closed
jholl opened this issue Jul 23, 2015 · 2 comments
Closed

[Form] Vendor styled input render too tall #2704

jholl opened this issue Jul 23, 2015 · 2 comments
Labels
Confirmed Bug
Milestone
2.1

Comments

@jholl
Copy link

jholl commented Jul 23, 2015

(Chrome 44)

screen shot 2015-07-22 at 11 22 28 pm
@jlukic
Copy link
Member

jlukic commented Jul 24, 2015

I'll take a look to see if this is solvable.

In the future please include a test case, this makes it easier to immediately begin debugging.

@jlukic jlukic added this to the 2.1 milestone Jul 24, 2015
@jlukic jlukic changed the title input[type="date"] renders slightly more height in default theme [Form] input[type="date"] renders slightly taller Aug 6, 2015
jlukic added a commit that referenced this issue Aug 10, 2015
@jlukic
Fixes calendar vendor styling in chrome being too damn tall #2704
650ed5a
jlukic added a commit that referenced this issue Aug 10, 2015
@jlukic
#2704 remove unused variable
938a32e
@jlukic
Copy link
Member

jlukic commented Aug 10, 2015

It looks like the vendor styled chromium inputs use 18px height for the "spinner", which is larger than any standard input line height. Had to manually set to @inputLineHeight

@jlukic jlukic closed this as completed Aug 10, 2015
@jlukic jlukic changed the title [Form] input[type="date"] renders slightly taller [Form] Vendor styled input render too tall Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@jlukic @jholl