-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#info
not producing tooltips in RTL MW UIs
#3514
Comments
The example is from page at: https://genderation.xyz/wiki/جوديث_بتلر , however I'm not sure the underlying template will stay the same, since it is a live production wiki. |
Thanks for reporting the issue. Any chance to get this on https://sandbox.semantic-mediawiki.org/ since I admittedly do not handle Arabic interfaces well? Moreover for 3.0.0 some work was done on this parser function. |
Thanks, Karsten, for your reply. I did some more testing and found out that either in sandbox or my wiki, when the wiki UI language is one written in non-Latin script, such as Arabic, Farsi, or Hebrew, the tooltip doesn't appear. But when the language is written in another script, it behaves as expected. Note that the issue may in fact be related to RTL scripts, since Syriac didn't work while Amharic worked. But I haven't tested that extensively. Another note which I think is relevant, is that while the page is still loading but haven't finished loading yet, the tip layer appears when the mouse hovers on the icon. However at that time the layer appears in black, i.e. unstyled in the style that is applied later on after the page has finished loading. (Merits of a slower internet connection, you get to say page genesis) |
Thanks a lot of recreating the issue on sandbox and elaborating on your findings. I had hoped that it might work on SMW 3.0.0 but not absolutely unexpected this version has issues with RTL, too. I do not think that it ever worked in earlier versions of SMW either. |
Another thing that caught my eye is that you have a |
I guess this is a decisive hint. I just created examples on sandbox and found that they are indeed producing pop ups. So I think you are doing something which is not possible within the current scope of the parser function if at all like e.g. a div inside a span. This latter is specific to your template I guess. |
The issue still manifests in the example you created, Karsten, when I
switch the Sandbox wiki UI language to one that is RTL.
To clarify, this is what I meant with my description of the tests I did
with the different languages, not the language of the string of #info
itself. Sorry, I wasn't clear enough.
…On 09 أكت, 2018 ص 09:22, Karsten Hoffmeyer wrote:
Another thing that caught my eye is that you have a div inside a span.
I guess this is a decisive hint. I just created examples on sandbox
<https://sandbox.semantic-mediawiki.org/wiki/Issue/3514> and found that
they are indeed producing pop ups. So I think you are doing something
which is not possible within the current scope of the parser function if
at all like e.g. a div inside a span. This latter is specific to your
template I guess.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3514 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACIY5LGOUNZeO1q8p6d9xMzkM_JcjMEdks5ujE7BgaJpZM4XMBLn>.
|
Thanks, Niklas!
I need to take a look at the HTML markup generated by the template
indeed. Mixing HTML and MediaWiki can be problematic, for this reason.
…On 09 أكت, 2018 ص 08:52, Niklas Laxström wrote:
Another thing that caught my eye is that you have a |div| inside a
|span|. This will get mangled in some way by Tidy or Remex (depending on
MediaWiki configuration and version).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3514 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACIY5BvKesU53tVnjBX6r068h4Y_K45hks5ujEfBgaJpZM4XMBLn>.
|
Affirmative, there is an issue. Admittedly I do not deal with RTL languages at all in my personal life. Using respective wikis is hardly to not possible too and I am not even talking about trying to edit. I guess this explains my ignorance here. Anyhow I added a comment to the page making it clear over there what needs to be done to recreate the issue. We standardly test against Japanese but this is obviously not an RTL. :| |
#info
not producing tooltip for RTL language users
#info
not producing tooltip for RTL language users#info
not producing tooltips for RTL language users
You might want to take a look at this some time, @maysara |
#info
not producing tooltips for RTL language users#info
not producing tooltips in RTL MW UIs
I had a quick look at it and it is clear that the tooltip (we use qTip2 [0]) is initialized before the content is displayed and gets in trouble when repositioning (calculating the pos of a RTL view) the particular tooltip instance. The only real alternative (after [0] is abandonware == hasn't seen any updates in the last 2 years) is to switch to a new lib preferable powered by Popper.js to use a real positioning engine. This isn't bug in or by SMW and can ultimately only be resolved by relying on a more modern tooltip facilitator such as tippyjs [1] which would require some effort and makes it an enhancement. [0] https://github.com/qTip2/qTip2 |
I had hoped that there will be an easier way to get this going for RTL users but reality is often even more complex than expected. |
Setup and configuration
Issue
The parser function #info produces an icon, but no tool-tip appears, neither when hovering nor when clicking on the info icon.
The produced HTML as per Special:ExpandTemplates:
However, what is actually in the page, as per Firefox inspector:
The text gets sanitized somewhere!
The text was updated successfully, but these errors were encountered: