Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to accommodate 1.27 #1440

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Changes to accommodate 1.27 #1440

merged 1 commit into from
Mar 9, 2016

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Mar 8, 2016

  • Various language changes because trying to get early access
    (during Setup) to Language::getCode violates MW's setup policy
    and is marked as such during the not completed wgFullyInitialised state.
  • Ensure that DeferredUpdates are finished before validating possible
    assertions (Support for DeferrableUpdate #1435)
  • Ensures wgExtraNamespaces is set to at least the canonical form
  • Ensures that a ExpResource is using the canonical form

refs #1424, #1295

@mwjames mwjames added the enhancement Alters an existing functionality or behaviour label Mar 8, 2016
@mwjames mwjames added this to the SMW 2.4 milestone Mar 8, 2016
@mwjames mwjames mentioned this pull request Mar 8, 2016
mwjames referenced this pull request Mar 8, 2016
@mwjames
Copy link
Contributor Author

mwjames commented Mar 8, 2016

Is there something in particular to test?

@kghbln To answer the question:

  • Property NS (its canonical form) should be set no matter what and is expected to solve Property namespace disappears (1.27) #1424 and most likely ConfirmEdit blocks SMW #1406
  • Switching a user language should work now like any other content in MW
  • If a predefined property (goes for core and extensions) doesn't have a localized label, the canonical (== English) label is supposed to be used
  • RDF will always use the canonical form (to my surprise encountered that my SPARQL RDF/Turtle would use the localized property labels and queries stopped working after I switched the user language ... what a drag ...)

PS: This would have all been easier if one could use Language::getCode early on but someone decide that for 1.27 (it worked before) you can't do that which brought all kinds of ... Anyway (for the predefined properties at least) switching languages is as easy as pressing the ULS button and labels are expected to adjust.

Namespace is a matter of the site language (not the user language). I was unable to find a way to extend wgNamespaceAliases with NS aliases at the time the user language changes.

image

image

- Various language changes because trying to get early access
(during `Setup`) to `Language::getCode` violates MW's setup policy
and is marked as such during the not completed `wgFullyInitialised` state.
- Ensure that `DeferredUpdates` are finished before validating possible
assertions (1435)
- Ensures `wgExtraNamespaces` is set to at least the canonical form
- Ensures that a `ExpResource` is using the canonical form
mwjames added a commit that referenced this pull request Mar 9, 2016
@mwjames mwjames merged commit b1dac1d into master Mar 9, 2016
@mwjames mwjames deleted the lang branch March 9, 2016 13:11
mwjames added a commit that referenced this pull request Mar 9, 2016
Set "userlang" in ParserOutput, refs #1440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Alters an existing functionality or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant