Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Special:Browse content via the API back-end #1756

Merged
merged 1 commit into from Aug 7, 2016
Merged

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Aug 4, 2016

This PR is made in reference to: N/A

This PR addresses or contains:

  • Display is served from an API request/response in order to increase responsiveness for pages with large fact sets
  • Special:Browse synchronous display characteristics is still available using output=legacy or $GLOBALS['smwgBrowseByApi'] = false
  • Design issues (html construction etc.) that are prominent in Special:Browse (and have moved to the HtmlContentBuilder) class has not been addressed as part of this PR and requires a follow-up

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added the enhancement Alters an existing functionality or behaviour label Aug 4, 2016
@mwjames mwjames added this to the SMW 2.5 milestone Aug 4, 2016
@mwjames
Copy link
Contributor Author

mwjames commented Aug 4, 2016

As in the outlined use case below (with 1.6 MB in retrievable data) doing a synchronous display (as it is now) will in most cases block the web browser for a length of time and create an unresponsive user interface.

image

@mwjames
Copy link
Contributor Author

mwjames commented Aug 4, 2016

@SemanticMediaWiki/testers Anyone wants to test this before I press the merge button?

- Display is served from an API request/response in order to increase
responsiveness for pages with large fact sets
- `Special:Browse` synchronous display characteristics is still available
using `output=legacy` or `$GLOBALS['smwgBrowseByApi'] = false`
@mwjames mwjames merged commit b88397c into master Aug 7, 2016
@mwjames mwjames deleted the browse-api branch August 7, 2016 18:16
mwjames added a commit that referenced this pull request Aug 8, 2016
mwjames added a commit that referenced this pull request Aug 24, 2016
Use prototype instead of ES6 class construct, refs #1756
mwjames added a commit that referenced this pull request Nov 12, 2016
mwjames added a commit that referenced this pull request Nov 12, 2016
@mwjames mwjames mentioned this pull request Feb 18, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Alters an existing functionality or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant