New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prototype instead of ES6 class construct, refs #1756 #1806

Merged

mwjames merged 1 commit into master from browse

Aug 24, 2016

Contributor

mwjames commented Aug 24, 2016 •

edited

This PR is made in reference to: #1756

This PR addresses or contains:

Instead of ES6 class syntax use the prototype constructor to avoid older browsers being excluded
Show an error message in case JS is disabled

This PR includes:

Tests (unit/integration)
CI build passed


          Use prototype instead of ES6 class construct, refs 1756

e8730e1

mwjames added this to the SMW 2.5 milestone

Contributor Author

mwjames commented Aug 24, 2016

mwjames merged commit 39308cb into master

mwjames deleted the browse branch

August 24, 2016 04:38

mwjames added a commit that referenced this pull request


          Special:Browse to use <noscript> to indicate missing JS + avoid conte…

2f34f75

…nt flashing, refs #1806

`<noscript>` [0] to avoid content flashing when JS is not available.

[0] http://www.w3schools.com/tags/tag_noscript.asp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment