add js geoitem geo #1822
Merged
add js geoitem geo #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| */ | ||
| getGeo: function() { | ||
| return this.geo; | ||
| } |
There was a problem hiding this comment.
What does "plain geo representation" mean? Are those coordinates as string, does this.geo return an object of lat, long or is it more something like 52° 30' 59", 13° 24' 0"?
The DI [0] returns an array of array( 'lat' => $this->latitude, 'lon' => $this->longitude ) so I'd expect something similar.
|
There is a lingering issue that got not addressed but I'm fine merging it since it covers the rudimentary use case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a js geoitem geo which I need for https://github.com/SemanticMediaWiki/SemanticMaps/ . This is still only a rough implementation (copy from dataitem.text.js).
This PR includes: