Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special page "SemanticStatistics", refs 2181 #2588

Merged
merged 3 commits into from
Aug 6, 2017

Conversation

mszabo-wikia
Copy link
Contributor

@mszabo-wikia mszabo-wikia commented Aug 2, 2017

This PR is made in reference to: #2181

This PR addresses or contains:

The information provided on this page has step by step been added to extend special page "Statistics". Special page "Statistics" now even provides more information that special page "SemanticStatistics" ever has. Thus it should probably be removed.

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #2181

@kghbln
Copy link
Member

kghbln commented Aug 2, 2017

Thanks for the pull! Just requested a review!

@JeroenDeDauw
Copy link
Member

Huh, we have no tag for breaking changes (from user perspective)?

I suppose since we are working on 3.0, it is indeed the time to remove this page. +2 from my side

@mwjames mwjames added this to the SMW 3.0.0 milestone Aug 5, 2017
@mwjames
Copy link
Contributor

mwjames commented Aug 5, 2017

@kghbln @Nikerabbit Before merging, I just want to make sure we don't get into any trouble where the semanticstatistics, smw_semstats_text key is deleted from other non-en i18n files.

@Nikerabbit
Copy link
Contributor

@mwjames Deletion is okay.

@mwjames
Copy link
Contributor

mwjames commented Aug 6, 2017

Thanks

@mwjames mwjames merged commit 148e794 into SemanticMediaWiki:master Aug 6, 2017
@mszabo-wikia mszabo-wikia deleted the remove-semantic-statistics branch August 6, 2017 18:32
@kghbln kghbln mentioned this pull request Sep 27, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants