Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove smwgSparqlDatabaseMaster / smwfGetSparqlDatabase #2750

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Remove smwgSparqlDatabaseMaster / smwfGetSparqlDatabase #2750

merged 1 commit into from
Oct 7, 2017

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Oct 7, 2017

This PR is made in reference to: #

This PR addresses or contains:

  • Removes setting $smwgSparqlDatabaseMaster and function smwfGetSparqlDatabase

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #

@mwjames mwjames added this to the SMW 3.0.0 milestone Oct 7, 2017
@mwjames mwjames merged commit 5e4e263 into master Oct 7, 2017
@mwjames mwjames deleted the sparql-remove branch October 7, 2017 22:43
@kghbln kghbln added the wikidocu missing Code changes (mostly features) what have not yet been documented label Nov 8, 2017
@kghbln
Copy link
Member

kghbln commented Nov 8, 2017

@mwjames What was the purpose of smwgSparqlDatabaseMaster? This was apparently never in "DefaultSettings.php" Was this an internal setting?

@mwjames
Copy link
Contributor Author

mwjames commented Nov 11, 2017

What was the purpose of smwgSparqlDatabaseMaster?

Beats me (I have a faint idea but it doesn't really matter now that it is removed).

This was apparently never in "DefaultSettings.php"

Yes.

Was this an internal setting?

Yes.

@kghbln
Copy link
Member

kghbln commented Nov 11, 2017

Thanks for the info. Just wanted to make sure!

@kghbln kghbln removed the wikidocu missing Code changes (mostly features) what have not yet been documented label Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SMW 3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mwjames @kghbln