Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redefinitions: #37

Merged
merged 2 commits into from
Nov 29, 2013
Merged

redefinitions: #37

merged 2 commits into from
Nov 29, 2013

Conversation

fallos
Copy link
Contributor

@fallos fallos commented Nov 28, 2013

usage_count=$dbtypes[i].
'i' => ( $wgDBtype == 'postgres' ? 'bigint' : 'INT(8)'.
To solve unit test issues point in comment 20 of bug 42659.
Following request in comment 23.

@fallos
redefinitions:
7402fa4 
  usage_count=$dbtypes[i].
  'i' => ( $wgDBtype == 'postgres' ? 'bigint' : 'INT(8)'.
   To solve unit test issues point in comment 20 of bug 42659.
    Following request in comment 23.
@mwjames
Copy link
Contributor

mwjames commented Nov 28, 2013

Thanks, the change you applied caused other tests to fail which means the current change needs adoption.

  1. SMW\Test\SQLStore\PropertyStatisticsTableTest::testInsertUsageCount with data set Get rid of manual autoloading code #42 (9001, 2147483648)
    Failed asserting that 2147483647 matches expected 2147483648.

/home/travis/build/SemanticMediaWiki/phase3/extensions/SemanticMediaWiki/tests/phpunit/includes/storage/sqlstore/PropertyStatisticsTableTest.php:99
/home/travis/build/SemanticMediaWiki/phase3/tests/phpunit/MediaWikiTestCase.php:123
/home/travis/build/SemanticMediaWiki/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/home/travis/build/SemanticMediaWiki/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:64

  1. SMW\Test\SQLStore\PropertyStatisticsTableTest::testAddToUsageCounts
    Failed asserting that two arrays are equal.
    --- Expected
    +++ Actual
    @@ @@
    Array (
    1 => 42
    2 => 42
    9001 => 1
  • 9002 => 2147483648
  • 9002 => 2147483647
    9003 => 1
    )

/home/travis/build/SemanticMediaWiki/phase3/extensions/SemanticMediaWiki/tests/phpunit/includes/storage/sqlstore/PropertyStatisticsTableTest.php:143

You can check the Travis-CI when clicking on the green or red icon next the the patch-set above.

@ghost ghost assigned JeroenDeDauw and mwjames Nov 28, 2013
@JeroenDeDauw
Copy link
Member

s/adoption/adaption

The breakage is caused by changing the type of usage_count. Perhaps you should just do this when postgres is used.

@mwjames
Copy link
Contributor

mwjames commented Nov 28, 2013

Independent from the distributed mysql tests, the above patch-set solved two issue but two issues remain for the postgres Travis-CI run which seems to be more of an issue of DatabasePostgres.php:481 (see [1]) rather than specific to SMW but I'd like to have them cleared as well in order to ensure proper implementation for all tests and all deployed platforms.

  1. SMW\Test\MediaWikiFunctionHookIntegrationTest::testOnArticlePurgeOnDatabase
    DatabasePostgres::reportQueryError: No transaction to rollback, something got out of sync! [Called from DatabaseBase::rollback in /home/travis/build/SemanticMediaWiki/phase3/includes/db/Database.php at line 3107]

/home/travis/build/SemanticMediaWiki/phase3/includes/debug/Debug.php:283
/home/travis/build/SemanticMediaWiki/phase3/includes/debug/Debug.php:144
/home/travis/build/SemanticMediaWiki/phase3/includes/GlobalFunctions.php:1105
/home/travis/build/SemanticMediaWiki/phase3/includes/db/Database.php:3107
/home/travis/build/SemanticMediaWiki/phase3/includes/db/DatabasePostgres.php:481
/home/travis/build/SemanticMediaWiki/phase3/includes/db/Database.php:983
/home/travis/build/SemanticMediaWiki/phase3/includes/db/Database.php:1434
/home/travis/build/SemanticMediaWiki/phase3/includes/Revision.php:372
/home/travis/build/SemanticMediaWiki/phase3/includes/Revision.php:314
/home/travis/build/SemanticMediaWiki/phase3/includes/Revision.php:294
/home/travis/build/SemanticMediaWiki/phase3/includes/Revision.php:143
/home/travis/build/SemanticMediaWiki/phase3/includes/WikiPage.php:575
/home/travis/build/SemanticMediaWiki/phase3/includes/WikiPage.php:615
/home/travis/build/SemanticMediaWiki/phase3/includes/WikiPage.php:2543
/home/travis/build/SemanticMediaWiki/phase3/includes/WikiPage.php:2477
/home/travis/build/SemanticMediaWiki/phase3/extensions/SemanticMediaWiki/tests/phpunit/integration/MediaWikiFunctionHookIntegrationTest.php:256
/home/travis/build/SemanticMediaWiki/phase3/extensions/SemanticMediaWiki/tests/phpunit/integration/MediaWikiFunctionHookIntegrationTest.php:140
/home/travis/build/SemanticMediaWiki/phase3/tests/phpunit/MediaWikiTestCase.php:116
/home/travis/build/SemanticMediaWiki/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:64
/home/travis/build/SemanticMediaWiki/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:48

  1. SMW\Test\MediaWikiFunctionHookIntegrationTest::testTitleMoveCompleteOnDatabase
    DatabasePostgres::reportQueryError: No transaction to rollback, something got out of sync! [Called from DatabaseBase::rollback in /home/travis/build/SemanticMediaWiki/phase3/includes/db/Database.php at line 3107]

/home/travis/build/SemanticMediaWiki/phase3/includes/debug/Debug.php:283
/home/travis/build/SemanticMediaWiki/phase3/includes/debug/Debug.php:144
/home/travis/build/SemanticMediaWiki/phase3/includes/GlobalFunctions.php:1105
/home/travis/build/SemanticMediaWiki/phase3/includes/db/Database.php:3107
/home/travis/build/SemanticMediaWiki/phase3/includes/db/DatabasePostgres.php:481
/home/travis/build/SemanticMediaWiki/phase3/includes/db/Database.php:983
/home/travis/build/SemanticMediaWiki/phase3/includes/db/Database.php:1434
/home/travis/build/SemanticMediaWiki/phase3/includes/Revision.php:372
/home/travis/build/SemanticMediaWiki/phase3/includes/Revision.php:314
/home/travis/build/SemanticMediaWiki/phase3/includes/Revision.php:294
/home/travis/build/SemanticMediaWiki/phase3/includes/Revision.php:143
/home/travis/build/SemanticMediaWiki/phase3/includes/WikiPage.php:575
/home/travis/build/SemanticMediaWiki/phase3/includes/WikiPage.php:615
/home/travis/build/SemanticMediaWiki/phase3/includes/WikiPage.php:2543
/home/travis/build/SemanticMediaWiki/phase3/includes/WikiPage.php:2477
/home/travis/build/SemanticMediaWiki/phase3/extensions/SemanticMediaWiki/tests/phpunit/integration/MediaWikiFunctionHookIntegrationTest.php:256
/home/travis/build/SemanticMediaWiki/phase3/extensions/SemanticMediaWiki/tests/phpunit/integration/MediaWikiFunctionHookIntegrationTest.php:206
/home/travis/build/SemanticMediaWiki/phase3/tests/phpunit/MediaWikiTestCase.php:116
/home/travis/build/SemanticMediaWiki/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:64
/home/travis/build/SemanticMediaWiki/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:48

[1] https://bugzilla.wikimedia.org/show_bug.cgi?id=44136

The issue that causes the MediaWikiFunctionHookIntegrationTest to fail is (line 256)

    if ( $wikiPage->exists() ) {
        $wikiPage->doDeleteArticle( "testing done on " . $on );
    }

which works on mysql and sqlite and should work on postgres as well.

@mwjames
Copy link
Contributor

mwjames commented Nov 28, 2013

Added [1] due to suspect doDeleteArticle() issue.

[1] https://bugzilla.wikimedia.org/show_bug.cgi?id=57724

@fallos
usage_count set to bigint only if when postgres is used.
42b2fcf 
redefinitions:
  usage_count=$dbtypes[i].
  'i' => ( $wgDBtype == 'postgres' ? 'bigint' : 'INT(8)'.
   To solve unit test issues point in comment 20 of bug 42659.
    Following request in comment 23.
JeroenDeDauw added a commit that referenced this pull request Nov 29, 2013
@JeroenDeDauw
Merge pull request #37 from fallos/postgresql
758d30a 
redefinitions:
@JeroenDeDauw JeroenDeDauw merged commit 758d30a into SemanticMediaWiki:postgresql Nov 29, 2013
@JeroenDeDauw
Copy link
Member

Awesome, thanks \o/

@otisyves otisyves mentioned this pull request May 3, 2018
Closed
@squirrelslair squirrelslair mentioned this pull request Oct 9, 2019
Closed
@robbienam robbienam mentioned this pull request Jun 11, 2020
Open
@EriqJB EriqJB mentioned this pull request Jan 11, 2023
Closed
@pav00 pav00 mentioned this pull request Mar 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JeroenDeDauw JeroenDeDauw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fallos @mwjames @JeroenDeDauw