Remove unused code (#421)

SemanticMediaWiki · Aug 28, 2018 · ac15b41 · ac15b41
1 parent 249923d
commit ac15b41
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 15 deletions.
diff --git a/formats/graphviz/SRF_Process.php b/formats/graphviz/SRF_Process.php
@@ -211,10 +211,8 @@ protected function getResultText( SMWQueryResult $res, $outputmode ) {
 		//
 		//	GraphViz settings
 		//
-		global $wgGraphVizSettings;
 		$this->isHTML 		= true;
 
-
 		//
 		//	Iterate all rows in result set
 		//

diff --git a/formats/jqplot/SRF_jqPlotSeries.php b/formats/jqplot/SRF_jqPlotSeries.php
@@ -135,7 +135,6 @@ private function getFormatSettings( $data, $options ) {
 
 		// Init
 		$dataSet =  [];
-		$grid =  [];
 		$options['mode'] = 'series';
 		$options['autoscale'] = false;
 

diff --git a/formats/outline/SRF_Outline.php b/formats/outline/SRF_Outline.php
@@ -189,7 +189,6 @@ protected function getResultText( SMWQueryResult $res, $outputmode ) {
 		while ( $row = $res->getNext() ) {
 			$item = new SRFOutlineItem( $row );
 			foreach ( $row as $field ) {
-				$first = true;
 				$field_name = $field->getPrintRequest()->getText( SMW_OUTPUT_HTML );
 				if ( in_array( $field_name, $this->mOutlineProperties ) ) {
 					while ( ( $object = $field->getNextDataValue() ) !== false ) {

diff --git a/formats/tagcloud/TagCloud.php b/formats/tagcloud/TagCloud.php
@@ -257,8 +257,6 @@ private function getTagCloud( array $tags ) {
 		// Initialize
 		$htmlTags      = [];
 		$processing    = '';
-		$htmlSTags     = '';
-		$htmlCTags     = '';
 
 		// Count actual output and store div identifier
 		$tagId = 'srf-' . uniqid();

diff --git a/formats/timeline/SRF_Timeline.php b/formats/timeline/SRF_Timeline.php
@@ -136,7 +136,6 @@ protected function getEventsHTML( SMWQueryResult $res, $outputmode, $isEventline
 			if ( $this->mTemplate != '' ) {
 				$this->hasTemplates = true;
 				$template_text = '';
-				$wikitext = '';
 				$i = 0;
 			}
 

diff --git a/formats/timeseries/SRF_Timeseries.php b/formats/timeseries/SRF_Timeseries.php
@@ -58,13 +58,10 @@ protected function getAggregatedTimeSeries( SMWQueryResult $result, $outputMode
 
 		while ( /* array of SMWResultArray */ $row = $result->getNext() ) { // Objects (pages)
 			$timeStamp = '';
-			$value     = '';
 			$series = [];
 
 			foreach ( $row as /* SMWResultArray */ $field ) {
-				$value  = [];
 				$sum    = [];
-				$rowSum = [];
 
 				// Group by subject (page object)  or property
 				if ( $this->params['group'] == 'subject' ){

diff --git a/formats/tree/TreeResultPrinter.php b/formats/tree/TreeResultPrinter.php
@@ -323,12 +323,9 @@ protected function buildTreeFromNodeList( $rootHash, $nodes ) {
 
 					try {
 						if ( array_key_exists( $parentHash, $nodes ) ) {
-							$errorCode = $nodes[ $parentHash ]->addChild( $node );
+							$nodes[ $parentHash ]->addChild( $node );
 						} elseif ( !$isRootSpecified ) {
-							$errorCode = $root->addChild( $node );
-						} else {
-							// Drop node. It is not part of the tree.
-							$errorCode = null;
+							$root->addChild( $node );
 						}
 					} catch ( Exception $e ) {
 						$this->addError( $e->getMessage(), $node->getResultSubject()->getTitle()->getPrefixedText() );