-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datatables and EventCalendar Stuck with Loading Dots #648
Comments
Thanks for reporting. This can also be observed on sandbox / eventcalendar and sandbox / datatables. The cause is probably Browser console gives this error:
|
TODO: Verify, if https://phabricator.wikimedia.org/T219604 is related |
See #621 |
So we need to break compat with 1.31 or is there another way? |
@kghbln I would definitely not break compat with 1.31 until both, SMW and SRF are fully ready for MW 1.35. If technically required, we should branch 4.x. |
Hello! I have the same issue. Just wanted to ask if there is an solution already? Thank you! |
@danielriedmueller you can try to patch your installation with fixes provided by #621 and share with us, if this worked for you. |
I replaced Resources.php with the the modified one from the patch, and now the error is gone and datatables is loading. |
I can also confirm that I can get datatables loading with the corrected Resources.php. |
In SimpleBatchUpload this code was added to help the cause: https://github.com/ProfessionalWiki/SimpleBatchUpload/blob/master/src/SimpleBatchUpload.php#L99 |
... we are at the moment fixing QUnit tests. There is definitely something in the water. Stay tuned. Ping @gesinn-it-wam . |
I guess in the meantime it is pointless to try adding some shim to support both MW 1.31 an 1.35. On 1.31 you need to use SRF 3.2.x and on MW 1.35 SRF 4.0.x. For SRF 4.0.x on MW 1.35.x the eventcalendar works gain. Thus closing. |
Setup
Issue
I tried to use the eventcalendar format for displaying a calendar in my personal wiki. The loading-dots never disappeared. I have tried to diagnose the issue; however, I have not been able to determine why the loading-dots never disappear. It appears that maybe the javascript for the eventcalendar is never loaded.
The same issue persists for datatables format as well.
Steps to reproduce
I cannot read French so using the sandbox is a little difficult.
Below are the steps.
Test calendar event
Category:Calendar test
Calendar test
Expected result:
Calendar will pull up.
Observed result:
Stuck with the loading "..." GIF.
Stacktrace
No stack trace.
The text was updated successfully, but these errors were encountered: