Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Resources.php #621

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Update Resources.php #621

merged 1 commit into from
Oct 15, 2021

Conversation

kizule
Copy link
Contributor

@kizule kizule commented Nov 13, 2020

Replaced all jquery.ui.* modules into the one, as all modules are merged into one.
Fixes: #619
Bug: T241335

Replaced all jquery.ui.* modules into the one, as all modules are merged into one.
Fixes #619
@kghbln
Copy link
Member

kghbln commented Nov 13, 2020

@kizule Thanks for the pull. Just one question: Which will be the new MW minimum requirement for this? I, e.g. do not expect MW 1.31 to be compatible which would be fine for this.

@JeroenDeDauw
Copy link
Member

I think this needs either 34 or 35.

@kizule
Copy link
Contributor Author

kizule commented Nov 13, 2020

I think that 1.35 would be correct, as it is new LTS release.

@JeroenDeDauw
Copy link
Member

My comment was about what this PR needs to work. Not which versions this extension should support. Though I do agree a sensible answer to the latter is 1.35.

@JeroenDeDauw
Copy link
Member

@kghbln I think we should just drop support for anything below MW 1.35 and PHP 7.3. If people really care about earlier versions they can always spend the effort of keeping that compat. I'm not willing to do this effort and people submitting patches like this one by and large also are not.

@kizule
Copy link
Contributor Author

kizule commented Nov 13, 2020

My comment was about what this PR needs to work. Not which versions this extension should support. Though I do agree a sensible answer to the latter is 1.35.

Okay, thanks. Current usage of jquery.ui* is here.

@gesinn-it-gea
Copy link
Member

To my opinion, we should not drop support for MW 1.31 (prev. LTS) as long as possible. A large number of wikis are in the field using 1.31. At least we should not drop support without branching, so that 3.x continues supporting 1.31 for a while and 4.x requires min 1.35.

@krabina
Copy link
Contributor

krabina commented Oct 4, 2021

I can confirm that this patch is working. As of September 30, MW 1.31 is EOL, so I guess it is ok to drop support for it.

@Seb35
Copy link
Contributor

Seb35 commented Oct 15, 2021

I also confirm this patch is working on MW 1.36. I find also that a 4.x branch should be created for MW ≥ 1.35, it will be easier to communicate MW 1.35+ ⇒ SRF 4.x, even if the branch 3.x becomes unmaintained.

@kghbln
Copy link
Member

kghbln commented Oct 15, 2021

@JeroenDeDauw Ready to merge?

@JeroenDeDauw JeroenDeDauw merged commit 1f39791 into SemanticMediaWiki:master Oct 15, 2021
@gesinn-it-gea gesinn-it-gea mentioned this pull request Nov 11, 2021
4 tasks
gesinn-it-gea added a commit that referenced this pull request Nov 11, 2021
Current master requires MW 1.35+ (#621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown module: jquery.ui.core
6 participants