-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Resources.php #621
Update Resources.php #621
Conversation
Replaced all jquery.ui.* modules into the one, as all modules are merged into one. Fixes #619
@kizule Thanks for the pull. Just one question: Which will be the new MW minimum requirement for this? I, e.g. do not expect MW 1.31 to be compatible which would be fine for this. |
I think this needs either 34 or 35. |
I think that 1.35 would be correct, as it is new LTS release. |
My comment was about what this PR needs to work. Not which versions this extension should support. Though I do agree a sensible answer to the latter is 1.35. |
@kghbln I think we should just drop support for anything below MW 1.35 and PHP 7.3. If people really care about earlier versions they can always spend the effort of keeping that compat. I'm not willing to do this effort and people submitting patches like this one by and large also are not. |
Okay, thanks. Current usage of jquery.ui* is here. |
To my opinion, we should not drop support for MW 1.31 (prev. LTS) as long as possible. A large number of wikis are in the field using 1.31. At least we should not drop support without branching, so that 3.x continues supporting 1.31 for a while and 4.x requires min 1.35. |
I can confirm that this patch is working. As of September 30, MW 1.31 is EOL, so I guess it is ok to drop support for it. |
I also confirm this patch is working on MW 1.36. I find also that a 4.x branch should be created for MW ≥ 1.35, it will be easier to communicate MW 1.35+ ⇒ SRF 4.x, even if the branch 3.x becomes unmaintained. |
@JeroenDeDauw Ready to merge? |
Current master requires MW 1.35+ (#621)
Replaced all jquery.ui.* modules into the one, as all modules are merged into one.
Fixes: #619
Bug: T241335