Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made excel export format enabled by default #21

Closed
wants to merge 1 commit into from
Closed

Made excel export format enabled by default #21

wants to merge 1 commit into from

Conversation

netbrain
Copy link
Contributor

Made excel export format enabled by default
Added PHPExcel as a suggested library through composer

If PHPExcel is not installed, the excel export format will output an error
message describing that PHPExcel is not installed and direct users to read on
documentation website on how to install it.

The error message however is only displayed when someone tries to use the excel format.

Also since composer.json now suggests the phpexcel library, it is given as an option to install when installing semantic result formats.

@JeroenDeDauw
Copy link
Member

So someone selecting "excel" from the dropdown on Special:Ask will get an error? It should really not show there unless it can actually be used.

@JeroenDeDauw
Copy link
Member

How about you enable it based on a class_exists call?

@netbrain
Copy link
Contributor Author

Thats exactly what im doing.

The error message only occurs if the required phpexcel library isnt
installed. In which case it tells the user to install the required library
before the format can be used.

This seems less of a hassle for end users then having to install library,
and then enable the library through a php file.
On Mar 14, 2014 4:06 PM, "Jeroen De Dauw" notifications@github.com wrote:

How about you enable it based on a class_exists call?

Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-37657022
.

@JeroenDeDauw
Copy link
Member

Thats exactly what im doing.

It seems like you are enabling the format regardless and then throwing an error when someone uses it and the library is not loaded. This is quite different from what I suggest, at least feature wise. It's one line of code to add...

@netbrain
Copy link
Contributor Author

Ah, i understand now. Ill add the excel format only if the class exists.

and added PHPExcel as a suggested library through composer

If PHPExcel is not installed, the excel export format will not be available
@JeroenDeDauw
Copy link
Member

Continuing in #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants