Enable the excel format by default is it can be loaded #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and added PHPExcel as a suggested library through composer If PHPExcel is not installed, the excel export format will not be available
Before a file with references to non-loaded code would still get parsed, that is not very nice.
|
@netbrain Now this looks fine to me. Please merge if you are fine with it. You now have push/merge rights on this repo, I trust you will use them responsibly. |
netbrain
added a commit
that referenced
this pull request
Mar 15, 2014
Enable the excel format by default is it can be loaded
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.