Update for new GraphViz extension class structure #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this compatible with MW 1.27? |
Also pass the dot source to GraphViz in a slightly more robust way (the args parameter was an empty string, but it should have been an array). Bug: T181926
|
Good point! I forgot about the parser service. Switched now; see what you think. |
JeroenDeDauw
reviewed
Jan 3, 2018
| @@ -112,7 +115,7 @@ protected function getResultText( SMWQueryResult $res, $outputmode ) { | |||
| $graphInput .= "}"; | |||
|
|
|||
| // Calls graphvizParserHook function from MediaWiki GraphViz extension | |||
| $result = GraphViz::graphvizParserHook( $graphInput, "", $GLOBALS['wgParser'], "" ); | |||
| $result = $wgParser->recursiveTagParse( "<graphviz>$graphInput</graphviz>" ); | |||
There was a problem hiding this comment.
$GLOBALS['wgParser'] is better in the sense that you do not pollute the whole function scope with the global
JeroenDeDauw
approved these changes
Jan 3, 2018
|
Does this change implies that GraphViz 3.+ is required? |
|
@mwjames: Thanks! And no, it works for old or new versions of GraphViz. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made in reference to: https://phabricator.wikimedia.org/T181926
This PR addresses or contains:
<graphviz>element, rather than directly calling the render method).This PR includes: