Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fullcalendar and added list views #384

Merged
merged 1 commit into from Mar 24, 2018

Conversation

nischayn22
Copy link
Member

@nischayn22 nischayn22 commented Mar 21, 2018

This PR addresses or contains:

  • Updated fullcalendar to the latest version. (FullCalendar v1.5.4 -> v3.9.0)
  • Added list views to event calendar format

Fixes: #252

@mwjames
Copy link
Contributor

mwjames commented Mar 24, 2018

Thanks but ...

... the change from FullCalendar v1.5.4 -> v3.9.0 contains various API changes and causes the eventcalendar to function in some part incorrectly (verified manually!). I could request to have this fixed but then I'm guessing you'd abort the PR (as it happens the last time) therefore as an exception I'll merge the PR and will add a follow-up.

  • themeSystem, eventSources (requires [ { } ]), defaultDate, onDayClick gets a Moment.js object instead of a date, extra buttons need a group to be have the correct design etc.

@mwjames mwjames merged commit 52f1e29 into SemanticMediaWiki:master Mar 24, 2018
@nischayn22
Copy link
Member Author

I could definitely try to fix the issue you have mentioned. I closed the PR when it required more than that, things like adding unit tests, etc.

Anyways, I think merging this is a huge step forward for this format. Could you please open a issue with steps to reproduce.

@mwjames
Copy link
Contributor

mwjames commented Mar 24, 2018

Anyways, I think merging this is a huge step forward for this format. Could you please open a issue with steps to reproduce.

I merged the follow-up (#385) with changes now being available at [0]. If time permits try to give it a spin to see whether something else is missing or not.

[0] https://sandbox.semantic-mediawiki.org/w/index.php?title=Sp%C3%A9cial:Ask&cl=YzoljstuhDAMRb8G70CIEUsv-tCo63bRtScYiAjJyDZD5-9rBukuTuyb5Pxh3b97vkjrrr3TxNXlzfPNYROJefIpPzib1v2np-qu9eV6tgcyhrHISoavTqDEeSCBFNdo2LcOeUFKCWamgUVR57KDMkmYE904YdM0VdeOm9jM4iSsWzKFgUdyeETeMUW1nXmB46S4lmxz1X3cSGP49bnzUTkQxihqAz3xZ3OVJ6iRuB5JiqwGiSdXxFwyg_-4Mr5egZBiWLw6sZ1LLX4Nirg1kgYo46i-a2GlmE_1fw

@nischayn22
Copy link
Member Author

listMonth doesn't work for me, see [0]. I think the last two replaces need to be inverted [1]

[0]https://goo.gl/9vXVzx
[1]https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/385/files#diff-89be5149c4980c6d7fd917570ed42848R85

@mwjames
Copy link
Contributor

mwjames commented Mar 24, 2018

listMonth doesn't work for me, see [0]. I think the last two replaces need to be inverted [1]

Allowed values are 'values' => [ 'month', 'basicweek', 'basicday', 'agendaweek', 'agendaday', 'listday', 'listweek', 'listmonth' ] which means listMonth is switched to month [0].

[0] https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/385/files#diff-607b55d2ae87a8789d503354fd74960fR52

@nischayn22
Copy link
Member Author

Using "listmonth" doesn't work and "month" doesn't show the list view.
https://goo.gl/ATTMqE

@mwjames
Copy link
Contributor

mwjames commented Mar 24, 2018

Using "listmonth" doesn't work and "month" doesn't show the list view.

Unless I'm missing something, it works for me [0].

[0] https://sandbox.semantic-mediawiki.org/wiki/Issue/SRF/384

@mwjames
Copy link
Contributor

mwjames commented Mar 24, 2018

Using "listmonth" doesn't work and "month" doesn't show the list view.

Changed to 681b438

@nischayn22
Copy link
Member Author

I was just typing:
It does work if the views are in that order. "Month,listDay,listmonth,listweek" works but "listmonth,listweek,Month,listDay" doesn't.

I think your fix should work. I have updated the example here: https://sandbox.semantic-mediawiki.org/wiki/Issue/SRF/384

@kghbln kghbln added this to the 3.0.0 milestone Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants