Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up fullcalendar v3.9.0 API changes, refs 384 #385

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Mar 24, 2018

This PR is made in reference to: #384

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames merged commit 705c27d into master Mar 24, 2018
@mwjames mwjames deleted the calendar-update branch March 24, 2018 10:33
mwjames added a commit that referenced this pull request Mar 24, 2018
@nischayn22
Copy link
Member

I have added a new example to https://sandbox.semantic-mediawiki.org/wiki/Issue/SRF/384
The following configuration doesn't work: views=basicday,month,listday,listmonth,listweek

When we are doing a replace of 'day' with 'Day' only the first occurrence is getting replaced in this example basicday becomes basicDay but listday remains listday and doesn't show up.

mwjames added a commit that referenced this pull request Mar 31, 2018
@mwjames
Copy link
Contributor Author

mwjames commented Mar 31, 2018

The following configuration doesn't work: views=basicday,month,listday,listmonth,listweek
When we are doing a replace of 'day' with 'Day' only the first occurrence is getting replaced in this example basicday becomes basicDay but listday remains listday and doesn't show up.

I suspect 983428f should fix that.

@nischayn22
Copy link
Member

Tested that it works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants