C#: Japanese Era and Leap Year checks (Likely Bugs) #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denislevin
changed the title
calumgrant
requested changes
May 22, 2019
|
|
||
| from Expr expr, string message | ||
| where | ||
| isDateFromJapaneseCalendarToDateTime(expr) and message = "DateTime created from Japanese calendar with explicit or current era and hard-coded year" or |
There was a problem hiding this comment.
Single quotes around DateTime
There was a problem hiding this comment.
Full stop at end of message.
| from Expr expr, string message | ||
| where | ||
| isDateFromJapaneseCalendarToDateTime(expr) and message = "DateTime created from Japanese calendar with explicit or current era and hard-coded year" or | ||
| isDateFromJapaneseCalendarCreation(expr) and message = "DateTime constructed from Japanese calendar with explicit or current era and hard-coded year" or |
There was a problem hiding this comment.
Single quotes and full stop.
| where | ||
| isDateFromJapaneseCalendarToDateTime(expr) and message = "DateTime created from Japanese calendar with explicit or current era and hard-coded year" or | ||
| isDateFromJapaneseCalendarCreation(expr) and message = "DateTime constructed from Japanese calendar with explicit or current era and hard-coded year" or | ||
| isEraCollectionCreation(expr) and message = "Hard-coded collection with Japanese era years" or |
| isDateFromJapaneseCalendarToDateTime(expr) and message = "DateTime created from Japanese calendar with explicit or current era and hard-coded year" or | ||
| isDateFromJapaneseCalendarCreation(expr) and message = "DateTime constructed from Japanese calendar with explicit or current era and hard-coded year" or | ||
| isEraCollectionCreation(expr) and message = "Hard-coded collection with Japanese era years" or | ||
| inEraArrayCreation (expr) and message = "Hard-coded array with Japanese era years" or |
| isDateFromJapaneseCalendarCreation(expr) and message = "DateTime constructed from Japanese calendar with explicit or current era and hard-coded year" or | ||
| isEraCollectionCreation(expr) and message = "Hard-coded collection with Japanese era years" or | ||
| inEraArrayCreation (expr) and message = "Hard-coded array with Japanese era years" or | ||
| isExactEraStartDateCreation(expr) and message = "Hard-coded the beginning of the Japanese Heisei era" |
hvitved
requested changes
May 24, 2019
csharp/ql/src/Likely Bugs/LeapYear/UnsafeYearConstruction.qhelp
Outdated
Show resolved
Hide resolved
csharp/ql/src/Likely Bugs/LeapYear/UnsafeYearConstruction.qhelp
Outdated
Show resolved
Hide resolved
csharp/ql/test/query-tests/Likely Bugs/LeapYear/AntiPattern1/options
Outdated
Show resolved
Hide resolved
csharp/ql/test/query-tests/Likely Bugs/LeapYear/AntiPattern1/Program.cs
Outdated
Show resolved
Hide resolved
csharp/ql/test/query-tests/Likely Bugs/LeapYear/AntiPattern1/MishandlingJapaneseEra.qlref
Outdated
Show resolved
Hide resolved
csharp/ql/test/query-tests/Likely Bugs/LeapYear/AntiPattern1/MishandlingJapaneseEra.expected
Outdated
Show resolved
Hide resolved
csharp/ql/test/query-tests/Likely Bugs/LeapYear/AntiPattern1/Program.cs
Outdated
Show resolved
Hide resolved
hvitved
reviewed
May 24, 2019
csharp/ql/src/Likely Bugs/LeapYear/UnsafeYearConstruction.qhelp
Outdated
Show resolved
Hide resolved
hvitved
reviewed
May 24, 2019
hvitved
requested changes
Jun 17, 2019
| @@ -0,0 +1,42 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Move this file, and others, from csharp/ql/test/query-tests/Likely Bugs/LeapYear/UnsafeYearConstruction/ to csharp/ql/test/query-tests/Likely Bugs/UnsafeYearConstruction/ (i.e., remove the nested LeapYear folder).
calumgrant
requested changes
Jun 17, 2019
csharp/ql/src/Likely Bugs/LeapYear/UnsafeYearConstruction.qhelp
Outdated
Show resolved
Hide resolved
csharp/ql/src/Likely Bugs/LeapYear/UnsafeYearConstructionBad.cs
Outdated
Show resolved
Hide resolved
csharp/ql/src/Likely Bugs/LeapYear/UnsafeYearConstructionGood.cs
Outdated
Show resolved
Hide resolved
csharp/ql/src/Likely Bugs/LeapYear/UnsafeYearConstructionGood.cs
Outdated
Show resolved
Hide resolved
hvitved
approved these changes
Jun 19, 2019
calumgrant
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSharp checks for mishandling Japanese date and leap year calculations