JavaScript: Teach resolveMainModule to try adding extensions.
#2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
package.jsonleaves off the extension of its main module, we previously weren't able to find it.An evaluation on big-apps.slugs suggests a slight slowdown overall, but nothing dramatic, and I suspect it may not be real anyway:
A2Z-F15showed a 6% slowdown first, which turned into a 3% speedup on rerunning, so it may just have been worker load. Should have run with DPMs.I doubt this affects many queries, so I didn't include a change note, but I'm happy to be convinced otherwise.