Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telescopeUrl env variable not set properly in Netlify builds #1589

Closed
humphd opened this issue Jan 22, 2021 · 1 comment · Fixed by #1591
Closed

telescopeUrl env variable not set properly in Netlify builds #1589

humphd opened this issue Jan 22, 2021 · 1 comment · Fixed by #1591
Labels
area: CI/CD Continuous integration / Continuous delivery area: front-end type: bug Something isn't working
Milestone
1.5 Release

Comments

@humphd
Copy link
Contributor

humphd commented Jan 22, 2021

When I load https://deploy-preview-1504--telescope-next.netlify.app/ for #1504, it looks like telescopeUrl is undefined on Netlify, it is loading this URL:

https://deploy-preview-1504--telescope-next.netlify.app/undefined/posts?page=1

We need to get the env to properly pass this up from the build into the frontend.
@humphd humphd added type: bug Something isn't working area: front-end area: CI/CD Continuous integration / Continuous delivery labels Jan 22, 2021
@humphd humphd mentioned this issue Jan 22, 2021
Merged
8 tasks
@humphd humphd added this to the 1.5 Release milestone Jan 22, 2021
@humphd
Copy link
Contributor Author

humphd commented Jan 22, 2021 

Unable to read root Telescope .env file

humphd added a commit to humphd/telescope that referenced this issue Jan 22, 2021
@humphd
Fix Seneca-CDOT#1589 - make sure that NEXT_PUBLIC_API_URL is set loca…
59a6b3a 
…lly and in Netlify
@humphd humphd mentioned this issue Jan 22, 2021
Merged
8 tasks
humphd added a commit that referenced this issue Jan 22, 2021
@humphd
Fix #1589 - make sure that NEXT_PUBLIC_API_URL is set locally and in …
52d9b5e 
…Netlify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: CI/CD Continuous integration / Continuous delivery area: front-end type: bug Something isn't working
Projects
None yet
Milestone
1.5 Release
Development

Successfully merging a pull request may close this issue.

Fix #1589 - make sure that NEXT_PUBLIC_API_URL is set locally and in Netlify humphd/telescope
1 participant
@humphd