Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1589 - make sure that NEXT_PUBLIC_API_URL is set locally and in Netlify #1591

Merged
merged 1 commit into from Jan 22, 2021

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Jan 22, 2021

Issue This PR Addresses

Fixes #1589

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

We need to set the NEXT_PUBLIC_API_URL in Netlify as well as locally. This sets it in the netlify.toml file.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@humphd humphd merged commit 52d9b5e into Seneca-CDOT:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

telescopeUrl env variable not set properly in Netlify builds
5 participants