Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve color contrast for slack icon in dark mode #2050

Closed
yuanLeeMidori opened this issue Mar 30, 2021 · 0 comments · Fixed by #2200
Closed

Improve color contrast for slack icon in dark mode #2050

yuanLeeMidori opened this issue Mar 30, 2021 · 0 comments · Fixed by #2200
Assignees
@yuanLeeMidori
Labels
area: accessibility Making Telescope accessible for all kinds of users area: front-end type: bug Something isn't working
Milestone
2.0 Release

Comments

@yuanLeeMidori
Copy link
Contributor

What happened:
image
In about footer, the slack icon is hard to see in dark mode.
What should have happened:

How to reproduce it (as precise as possible):

Anything else we need to know?:

Environment:

  • OS:
  • Browser:
@yuanLeeMidori yuanLeeMidori added type: bug Something isn't working area: front-end labels Mar 30, 2021
@yuanLeeMidori yuanLeeMidori added this to the 1.9.5 Release milestone Mar 30, 2021
@yuanLeeMidori yuanLeeMidori added the area: accessibility Making Telescope accessible for all kinds of users label Mar 30, 2021
@yuanLeeMidori yuanLeeMidori self-assigned this Mar 30, 2021
@yuanLeeMidori yuanLeeMidori mentioned this issue Apr 21, 2021
Merged
8 tasks
yuanLeeMidori added a commit that referenced this issue Apr 23, 2021
@yuanLeeMidori
fix #2050: Improve slack icon contrast ratio (#2200)
c426005 
* Change slack icon to react icon

* Update snapshot for jest and remove slack icon file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuanLeeMidori yuanLeeMidori

Labels
area: accessibility Making Telescope accessible for all kinds of users area: front-end type: bug Something isn't working
Projects
None yet
Milestone
2.0 Release
Development

Successfully merging a pull request may close this issue.

fix #2050: Improve slack icon contrast ratio yuanLeeMidori/telescope
1 participant
@yuanLeeMidori