Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from bent to node-fetch #206

Closed
manekenpix opened this issue Nov 15, 2019 · 1 comment · Fixed by #254
Closed

Switch from bent to node-fetch #206

manekenpix opened this issue Nov 15, 2019 · 1 comment · Fixed by #254
Assignees
@hansal7014
Labels
area: back-end type: enhancement New feature or request

Comments

@manekenpix
Copy link
Member

Right now, telescope is using both bent and node-fetch for requests. To avoid having multiple dependencies for doing the same, we should go with just one of them. node-fetch seems to be a bit more versatile than bent, so it'd be a good idea to replace it with node-fetch wherever is used.
@manekenpix manekenpix changed the title Switch from 'bent' to 'node-fetch' Switch from bent to node-fetch Nov 15, 2019
@hansal7014
Copy link
Contributor

Hi @manekenpix,
I would like to work on this. Thanks.

@hansal7014 hansal7014 self-assigned this Nov 15, 2019
@hansal7014 hansal7014 mentioned this issue Nov 17, 2019
Merged
humphd pushed a commit that referenced this issue Nov 17, 2019
@hansal7014 @humphd
Fixes #206 - Refactor code to use node-fetch instead of Bent (#254)
c1d8eba 
* Refactor code to use node-fetch instead of bent

* Remove bent from dependencies.

* Fix lint errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansal7014 hansal7014

Labels
area: back-end type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #206 - Refactor code to use node-fetch instead of Bent hansal7014/telescope
2 participants
@manekenpix @hansal7014