Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusting the proxy #3792

Closed
sfrunza13 opened this issue Jan 25, 2023 · 0 comments · Fixed by #3793
Closed

Trusting the proxy #3792

sfrunza13 opened this issue Jan 25, 2023 · 0 comments · Fixed by #3793
Labels
type: enhancement New feature or request

Comments

@sfrunza13
Copy link
Contributor

sfrunza13 commented Jan 25, 2023

What would you like to be added:

We could try to add trust for proxy in case this makes a difference with the session cookie.secure set to true since we are using nginx.

var app = express()
app.set('trust proxy', 1) // trust first proxy
app.use(session({
...

Why would you like this to be added:

In the express-session docs they claim this trust should be set if cookie.secure is set to true. This is a part of an ongoing effort to get cookies to send within the post binding part of the Azure AD authentication which I broke with #3789. Could be contributing/considered along with the latest issue #3791.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant