Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a Test that ensure's the email ability is working correctly #82

Closed
neilong31 opened this issue Nov 7, 2019 · 1 comment · Fixed by #198
Closed

Creating a Test that ensure's the email ability is working correctly #82

neilong31 opened this issue Nov 7, 2019 · 1 comment · Fixed by #198
Assignees
@neilong31
Labels
type: test Creation and development of test

Comments

@neilong31
Copy link
Contributor

Creates testing for feature in #25

I will be using nodemailer and ethereal to test that the we are able to send emails out.

Similar to https://nodemailer.com/smtp/testing/
@neilong31 neilong31 self-assigned this Nov 7, 2019
@RyanWils RyanWils closed this as completed Nov 7, 2019
@RyanWils RyanWils reopened this Nov 7, 2019
@RyanWils
Copy link
Contributor

RyanWils commented Nov 7, 2019 •
edited
Loading

Hi Neil,
I have submitted a PR for a basic email sending function using Nodemailer.
.env variables must be used for the username/password as shown by my mistake, issue #93.
Sorry I miss clicked on the close issue button.

@Immutablevoid Immutablevoid added the type: test Creation and development of test label Nov 7, 2019
@RyanWils RyanWils mentioned this issue Nov 7, 2019
Merged
@neilong31 neilong31 mentioned this issue Nov 15, 2019
Merged
neilong31 added a commit to neilong31/telescope that referenced this issue Nov 15, 2019
@neilong31
Fix Seneca-CDOT#82: Create tests for email feature
6b4c95e 
Fixed some errors found in email tester

Fixed Linting errors

Fixed linting errors Seneca-CDOT#2

Fixed linting errors Seneca-CDOT#3

Fixed build errors

Fixed tested to ensure resolve is correct
neilong31 added a commit to neilong31/telescope that referenced this issue Nov 15, 2019
@neilong31
Fix Seneca-CDOT#82: Create tests for email feature
c75ebc6 
Fixed some errors found in email tester

Fixed Linting errors

Fixed linting errors Seneca-CDOT#2

Fixed linting errors Seneca-CDOT#3

Fixed build errors

Fixed tested to ensure resolve is correct
@renovate renovate bot mentioned this issue Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neilong31 neilong31

Labels
type: test Creation and development of test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added tests for email-sender.js neilong31/telescope
4 participants
@Immutablevoid @neilong31 @Reza-Rajabi @RyanWils