Fixes #118: added stylelint #125
Conversation
|
I've hooked the stylelint script to the test script. Please review my changes. Adding npm-run-all can be filed as another issue. |
This is great, it would have caught the issue in #117. |
.stylelintrc.js
Outdated
| "!*.css" | ||
| ], | ||
| rules: { | ||
| "at-rule-no-unknown": true, |
There was a problem hiding this comment.
Question: why not just use the standard config of rules in https://github.com/stylelint/stylelint-config-standard? How did you arrive at this set of rules?
There was a problem hiding this comment.
I used https://github.com/stylelint/stylelint-config-recommended , should I use the standard config instead of recommended?
There was a problem hiding this comment.
Instead of manually defining these rules, you can install the recommended:
npm install stylelint-config-recommended --save-dev
and then use
"extends": "stylelint-config-recommended"
And you don't/won't have to specify all these. You'd only use these rules if you wanted to override something, which we might. This is very similar to what we're doing in eslint with the Airbnb ruleset
package.json
Outdated
| "jest": "^24.9.0" | ||
| "jest": "^24.9.0", | ||
| "stylelint": "^11.1.1", | ||
| "stylelint-webpack-plugin": "^1.0.3" |
There was a problem hiding this comment.
Sorry, this was a mistake. I thought we need both stylelint and stylelint-webpack-plugin for stylelint to work. I'll remove it
|
I'm excited to see this land, as it will help us catch bugs faster in review for subsequent PRs. |
Added style lint to catch invalid css styles
How to run script:
npm run stylelintThis PR successfully picks up the
h1cinvalid css selector in planet.cssFixes #118