Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #118: added stylelint #125

Merged
merged 3 commits into from Nov 11, 2019
Merged

Fixes #118: added stylelint #125

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c517cc0
added stylelint
cindyledev Nov 9, 2019
eb874ca
hooked stylelint script to test script
cindyledev Nov 10, 2019
c8c0f8f
added stylelint-config-rec dep
cindyledev Nov 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 43 additions & 0 deletions .stylelintrc.js
View file
Open in desktop
@@ -0,0 +1,43 @@
"use strict";

module.exports = {
"ignoreFiles": [
"Dockerfile",
"LICENSE",
"*.*",
"images/*.*",
"!*.css"
],
rules: {
"at-rule-no-unknown": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: why not just use the standard config of rules in https://github.com/stylelint/stylelint-config-standard? How did you arrive at this set of rules?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used https://github.com/stylelint/stylelint-config-recommended , should I use the standard config instead of recommended?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of manually defining these rules, you can install the recommended:

npm install stylelint-config-recommended --save-dev

and then use

  "extends": "stylelint-config-recommended"

And you don't/won't have to specify all these. You'd only use these rules if you wanted to override something, which we might. This is very similar to what we're doing in eslint with the Airbnb ruleset

"block-no-empty": true,
"color-no-invalid-hex": true,
"comment-no-empty": true,
"declaration-block-no-duplicate-properties": [
true,
{
ignore: ["consecutive-duplicates-with-different-values"]
}
],
"declaration-block-no-shorthand-property-overrides": true,
"font-family-no-duplicate-names": true,
"font-family-no-missing-generic-family-keyword": true,
"function-calc-no-invalid": true,
"function-calc-no-unspaced-operator": true,
"function-linear-gradient-no-nonstandard-direction": true,
"keyframe-declaration-no-important": true,
"media-feature-name-no-unknown": true,
"no-descending-specificity": true,
"no-duplicate-at-import-rules": true,
"no-duplicate-selectors": true,
"no-empty-source": true,
"no-extra-semicolons": true,
"no-invalid-double-slash-comments": true,
"property-no-unknown": true,
"selector-pseudo-class-no-unknown": true,
"selector-pseudo-element-no-unknown": true,
"selector-type-no-unknown": true,
"string-no-newline": true,
"unit-no-unknown": true
}
};