Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #133 - Silenced npm logs when builds fail #138

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Fixes #133 - Silenced npm logs when builds fail #138

merged 1 commit into from
Nov 11, 2019

Conversation

zufishanali
Copy link
Contributor

@zufishanali zufishanali commented Nov 11, 2019 •
edited
Loading

Fixes #133

Added file .npmrc as instructed in-order to suppress npm error logs.

@zufishanali zufishanali changed the title Fixes ISilenced npm logs when builds fail Fixes #133 - Silenced npm logs when builds fail Nov 11, 2019
humphd
humphd approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already a huge improvement, if you look at the failing build log in Travis now, it's missing all the extra npm noise.

Nice work, and thanks for doing this so quickly!

@s-arika s-arika self-requested a review November 11, 2019 02:16
s-arika
s-arika reviewed Nov 11, 2019
View reviewed changes
Copy link

@s-arika s-arika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cindyorangis cindyorangis self-requested a review November 11, 2019 02:20
@humphd humphd merged commit ac25059 into Seneca-CDOT:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@s-arika s-arika s-arika approved these changes

@cindyorangis cindyorangis cindyorangis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silence npm logs when builds fail
5 participants
@zufishanali @humphd @s-arika @cindyorangis @Reza-Rajabi