-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] Item 2 and 4 related to /styles/global.css of Issue #1548 #1562
[next] Item 2 and 4 related to /styles/global.css of Issue #1548 #1562
Conversation
You can set global style in MUI too. We can either do Next global styling or put everything in MUi |
@PedroFonsecaDEV : Here. https://material-ui.com/customization/globals/. But putting all of global.css content to MUI will make the theming too big. Maybe just some of the properties. |
|
||
/* -------------------------------------------------- */ | ||
|
||
/* telescope-post-content.css */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of doing this inside global.css
, can you move this to its own file: src/frontend/next/src/styles/telescope-post-content.css
and do an @import
here to include it.
We need to do the same with the highlight-js CSS stylesheet for our code formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@humphd I could not find the file highlight-js
. Could you please provide the path to me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to install the highlightjs package to next/, then pull the CSS file from node_modules:
"highlight.js": "10.4.1",
Then we can use node_modules/highlight.js/styles/github.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Let's do it in a follow-up.
3297f9b
to
d79d1da
Compare
d79d1da
to
17d26aa
Compare
This is ready to go, @PedroFonsecaDEV, land when ready. |
Issue This PR Addresses
This PR solves item 2 and 4 of the issue: #1548
Type of Change
Description
This PR solves item 2 and 4 of the issue: #1548
Regards item 2:
This CSS is coming from PageBase
Not sure if it needed to set
I think it's a good idea.
@tonyvugithub Do you know if MUI has something related to resetting padding or margin?
Regards item 4:
#1504 (comment)
Checklist