Fixes: 1595 - [next] Infinite Scrolling of Posts is broken (All of our infinite scrolls were broken) #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-disable-next-line react-hooks/exhaustive-deps LINE 45
File: LoadAutoScroll.tsx
eslint-disable-next-line react-hooks/exhaustive-deps
LINE 48
File: LoadAutoScroll.tsx
PedroFonsecaDEV
requested review from
chrispinkney,
yuanLeeMidori,
HyperTHD and
Metropass
|
@PedroFonsecaDEV : Seem to be a quick fix, good job! |
tonyvugithub
approved these changes
Jan 27, 2021
humphd
reviewed
Jan 27, 2021
| @@ -44,12 +44,13 @@ function LoadAutoScroll({ onScroll }: Scroll) { | |||
| return () => { | |||
| observer.unobserve(buttonRefCopy as HTMLButtonElement); | |||
| }; | |||
| }, [$buttonRef, onScroll]); | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
There was a problem hiding this comment.
We should file a follow-up to figure out why our eslint doesn't like [] since I'd say it's a valid use case to not define deps, but want a one-time effect.
DukeManh
pushed a commit
to DukeManh/telescope
that referenced
this pull request
Feb 5, 2021
…r infinite scrolls were broken) (Seneca-CDOT#1614)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #1595
Type of Change
Description
After landed the PR: #1573 created a bug inside our
LoadAutoScroll's useEffect both for our Gatsby and Next. This PR will fix the warning issue and fix all of our infinite scroll problems for Gatsby and Next (homepage and search page).Checklist