Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1227] Fixed Eslint warnings #1573

Merged
merged 1 commit into from
Jan 20, 2021
Merged

[1227] Fixed Eslint warnings #1573

merged 1 commit into from
Jan 20, 2021

Conversation

birtony
Copy link
Contributor

@birtony birtony commented Jan 20, 2021

Issue This PR Addresses

Fixes #1227

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

@ceterisp has originally worked on issue #1227 in #1391. I have looked at the warnings Eslint used to throw and there wasn't anything related to https://github.com/Seneca-CDOT/telescope/pull/1391/files#diff-53149432e2cca92090a6cb3603c9570f20ebf6546280484ece66ab937794283bR79. All of the warnings should be addressed in this pr. Therefore, when merged, I'd suggest closing #1391

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@birtony birtony added type: bug Something isn't working area: back-end area: front-end developer experience Helping the Developer Experience labels Jan 20, 2021
@birtony birtony added this to the 1.5 Release milestone Jan 20, 2021
@birtony birtony self-assigned this Jan 20, 2021
@birtony birtony marked this pull request as ready for review January 20, 2021 17:36
humphd
humphd requested changes Jan 20, 2021
View reviewed changes
src/frontend/gatsby/src/components/Post/Post.jsx Outdated Show resolved Hide resolved
src/frontend/gatsby/src/components/Posts/Posts.jsx Outdated Show resolved Hide resolved
@birtony birtony force-pushed the issue1227-fix-eslint-warnings branch from 5ffb76c to 7fa49e4 Compare January 20, 2021 17:46
@birtony birtony requested a review from humphd January 20, 2021 17:47
@humphd humphd merged commit 6cfd7df into master Jan 20, 2021
@humphd humphd deleted the issue1227-fix-eslint-warnings branch January 20, 2021 19:31
@humphd
Copy link
Contributor

humphd commented Jan 20, 2021

I am so happy to have these lint issues cleaned up!

@birtony birtony mentioned this pull request Jan 20, 2021
Closed
8 tasks
@PedroFonsecaDEV PedroFonsecaDEV mentioned this pull request Jan 27, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@HyperTHD HyperTHD HyperTHD approved these changes

@manekenpix manekenpix Awaiting requested review from manekenpix

@chrispinkney chrispinkney Awaiting requested review from chrispinkney

@tonyvugithub tonyvugithub Awaiting requested review from tonyvugithub

Assignees

@birtony birtony

Labels
area: back-end area: front-end developer experience Helping the Developer Experience type: bug Something isn't working
Projects
None yet
Milestone
1.5 Release
Development

Successfully merging this pull request may close these issues.

Fix eslint warnings spamming our PRs
3 participants
@birtony @humphd @HyperTHD