netlify: force rebuild with every merge to avoid 'failed' message in badge #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manekenpix
requested review from
humphd,
chrispinkney,
HyperTHD,
birtony,
tonyvugithub and
PedroFonsecaDEV
manekenpix
changed the title
manekenpix
force-pushed
the
fix-netlify-badge
branch
from
a5383e8
to
c89b512
Compare
PedroFonsecaDEV
previously approved these changes
Feb 3, 2021
birtony
previously approved these changes
Feb 3, 2021
humphd
requested changes
Feb 3, 2021
| @@ -2,6 +2,7 @@ | |||
| base = "src/frontend/next/" | |||
| publish = "out" | |||
| command = "npm run build" | |||
| ignore = "/bin/false" | |||
There was a problem hiding this comment.
Let's add a comment above this line linking to this PR, which documents why we do this.
manekenpix
dismissed stale reviews from chrispinkney, birtony, and PedroFonsecaDEV
via
af634f2
manekenpix
force-pushed
the
fix-netlify-badge
branch
from
c89b512
to
af634f2
Compare
birtony
previously approved these changes
Feb 3, 2021
humphd
previously approved these changes
Feb 3, 2021
manekenpix
force-pushed
the
fix-netlify-badge
branch
from
af634f2
to
7621974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever a PR is merged and no changes were made to
next, our badge reports afailedbuild. This happens becausenetlifydetects that no changes were made to thenextfront-end and cancels the build, and for some reason it considers this a failed attempt.This bug has been reported, and it seems that the solution to avoid this behavior (for now) is to force a build even when no changes were made to the
nextfront-end.This PR makes the necessary changes to our
netlify.tomlto force thenextbuild.