Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix# 182 updated .travis.yml #188

Closed
wants to merge 51 commits into from
Closed

Fix# 182 updated .travis.yml #188

wants to merge 51 commits into from

Conversation

Manan311
Copy link
Contributor

Added os support for windows and mac.
#182

@humphd
Copy link
Contributor

humphd commented Nov 14, 2019

Looks like macOS doesn't support services: Services are not supported on osx. We probably have to [homebrew](use https://docs.travis-ci.com/user/reference/osx#homebrew) to install it, see https://gist.github.com/tomysmile/1b8a321e7c58499ef9f9441b2faa0aa8.

For the Windows failure, see jasongin/nvs#122 (comment)

@Manan311
Copy link
Contributor Author

Looks like macOS doesn't support services: Services are not supported on osx. We probably have to [homebrew](use https://docs.travis-ci.com/user/reference/osx#homebrew) to install it, see https://gist.github.com/tomysmile/1b8a321e7c58499ef9f9441b2faa0aa8.

For the Windows failure, see jasongin/nvs#122 (comment)

Thank you I was looking at mac os homebrew as well on Travis ci reference web and i will look into windows as well.

Ryan Wilson and others added 21 commits November 14, 2019 14:24
fix #174:Moved files to frontend and changed paths
Fix #75: Added Fragmentation to HTML to text Parser
Fix #25: Implement basic email sender
* Fix #74: Validade blog URLs.

* Fix #74: fixed lines at the end of file
* Added feed list parser

* Update package.json

* second commit for parser issue#59

* second commit for parser issue#59

* split into functions and added .env

* fixed lint issues and removed console.log

* commit with updated branch

* fixed requested changes

* created array of objects
* Add logging support for the project.

* Add documentation for logging support.

* Update package-lock.json for successful CI build

* Fix links in docs

* Adds requested review changes.

* Move doc images to docs/images

* Update logic to use LOG_FILE env variable

* Update env.example as per review comments.

* Refactor conditional logic for process.env.LOG_FILE

* Update documentation to reflect current logger code.
Fixed bugs and added export

Added 'parse'github'url' and 'node-fetch'

Added support for user url

Added test for user url

Added 'GITHUB_TOKEN'

Added using 'process.env.GITHUB_TOKEN' as a query parameter
Closes #54: Fetch data from GitHub API
@humphd
Copy link
Contributor

humphd commented Nov 15, 2019

Why do we have 2 PRs on this, see also #212. @Manan311 please close whichever one you aren't working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet