Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link colors to palette; change link color in dark mode about page #2082

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

yuanLeeMidori
Copy link
Contributor

Issue This PR Addresses

Fixes: #2048
Related to: #2047

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Before:
Screenshot_2021-04-05 About Telescope
Screenshot_2021-04-05 About Telescope(2)
After:
Screenshot_2021-04-05 About Telescope(1)
Screenshot_2021-04-05 About Telescope(3)

Basically, they're now using the same colors as posts, both light mode and dark mode. Please let me know if you prefer original colors for light mode about page.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@yuanLeeMidori yuanLeeMidori added type: bug Something isn't working area: front-end area: css styling Anything related to CSS styling area: accessibility Making Telescope accessible for all kinds of users labels Apr 5, 2021
@yuanLeeMidori yuanLeeMidori added this to the 1.9.5 Release milestone Apr 5, 2021
@yuanLeeMidori yuanLeeMidori self-assigned this Apr 5, 2021
@PedroFonsecaDEV
Copy link
Contributor

@DukeManh @izhuravlev Could you please review this one?

rjayroso
rjayroso previously approved these changes Apr 5, 2021
Copy link
Contributor

@rjayroso rjayroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can definitely see the links/active links in dark mode better, IMO

@HyperTHD
Copy link
Contributor

HyperTHD commented Apr 6, 2021

Dark mode looks good, but it's so difficult to see the links in light mode with the new link colors. If you could switch that back to what we had before, that'd be great

@yuanLeeMidori
Copy link
Contributor Author

@HyperTHD Which one? Visited or unvisited one? They actually both pass WCAG AAA rating. Maybe I should make the font bolder?

@HyperTHD
Copy link
Contributor

HyperTHD commented Apr 6, 2021

@HyperTHD Which one? Visited or unvisited one? They actually both pass WCAG AAA rating. Maybe I should make the font bolder?

It's the not-visited color. It's very difficult for me to see without zooming up the page

Copy link
Contributor

@birtony birtony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also find the visited link colour on the light mode to be hard to see. Maybe we should use different colours for dark/light mode? @yuanLeeMidori

@yuanLeeMidori
Copy link
Contributor Author

I've updated the link colors for light mode. This also affect post in timeline.

Post:
Screenshot_2021-04-06 Telescope

About:
Screenshot_2021-04-06 About Telescope

Please let me know your thoughts! @HyperTHD @birtony @PedroFonsecaDEV @rjayroso

Copy link
Contributor

@HyperTHD HyperTHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better.
Nice job, @yuanLeeMidori. Get this rebased and you can merge

@yuanLeeMidori yuanLeeMidori merged commit c5b02ba into Seneca-CDOT:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: accessibility Making Telescope accessible for all kinds of users area: css styling Anything related to CSS styling area: front-end type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode about page link colors are hard to see
5 participants