-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link colors to palette; change link color in dark mode about page #2082
Conversation
@DukeManh @izhuravlev Could you please review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can definitely see the links/active links in dark mode better, IMO
Dark mode looks good, but it's so difficult to see the links in light mode with the new link colors. If you could switch that back to what we had before, that'd be great |
@HyperTHD Which one? Visited or unvisited one? They actually both pass WCAG AAA rating. Maybe I should make the font bolder? |
It's the not-visited color. It's very difficult for me to see without zooming up the page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also find the visited link colour on the light mode to be hard to see. Maybe we should use different colours for dark/light mode? @yuanLeeMidori
879c702
to
c93537c
Compare
I've updated the link colors for light mode. This also affect post in timeline. Please let me know your thoughts! @HyperTHD @birtony @PedroFonsecaDEV @rjayroso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better.
Nice job, @yuanLeeMidori. Get this rebased and you can merge
Issue This PR Addresses
Fixes: #2048
Related to: #2047
Type of Change
Description
Before:
After:
Basically, they're now using the same colors as posts, both light mode and dark mode. Please let me know if you prefer original colors for light mode about page.
Checklist