Feature/search microservice #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izhuravlev
force-pushed
the
feature/search-microservice
branch
from
48b36ee
to
7875157
Compare
8 tasks
chrispinkney
requested changes
Apr 9, 2021
humphd
requested changes
Apr 9, 2021
chrispinkney
requested changes
Apr 9, 2021
|
This needs a rebase to deal with the Parser service landing just now. |
…backend fixes: missing variables from port adds: documentation updates and code cleanup adds: corrections based on feedback and improvements adds: port of original tests (failing WIP) fixes: rebase issues and updates docker env
izhuravlev
force-pushed
the
feature/search-microservice
branch
from
7875157
to
14a8fb4
Compare
humphd
previously approved these changes
Apr 9, 2021
src/api/search/Dockerfile
Outdated
| RUN apk add dumb-init | ||
|
|
||
| # Force production env, regardless of what we get from .env | ||
| ENV NODE_ENV production |
izhuravlev
force-pushed
the
feature/search-microservice
branch
from
14a8fb4
to
f395dc2
Compare
humphd
approved these changes
Apr 9, 2021
PedroFonsecaDEV
approved these changes
Apr 9, 2021
chrispinkney
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Updated #1802
Closes #1737
Type of Change
Description
Adds support for
search.docker.localhost, which ports the original ELK query controller to a dedicated service. The following is added as a warning to not work further on the original codebase for querying:NOTE: The tests will be done in the follow-up to this PR.
Checklist