Fix Banner Observer and NavBar rendering when using snap-scroll or scroll down button. #2175

PedroFonsecaDEV · 2021-04-19T11:43:49Z

Issue This PR Addresses

This PR fixes our issue regarding the NavBar not showing up after triggering the scroll-snap or the scroll-down button on our landing page.

To test it, please use the Vercel deployment.

Quality: This PR builds and passes our npm test and works locally
Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

PedroFonsecaDEV · 2021-04-19T16:39:00Z

Rebasing and merging.

PedroFonsecaDEV added the area: front-end label Apr 19, 2021

PedroFonsecaDEV added this to the 2.0 Release milestone Apr 19, 2021

PedroFonsecaDEV requested review from chrispinkney, yuanLeeMidori and DukeManh April 19, 2021 11:43

PedroFonsecaDEV self-assigned this Apr 19, 2021

vercel bot deployed to Preview April 19, 2021 11:43 View deployment

PedroFonsecaDEV requested review from humphd and manekenpix April 19, 2021 11:44

HyperTHD previously approved these changes Apr 19, 2021

View reviewed changes

yuanLeeMidori previously approved these changes Apr 19, 2021

View reviewed changes

PedroFonsecaDEV dismissed stale reviews from yuanLeeMidori and HyperTHD via 96ecd96 April 19, 2021 16:38

PedroFonsecaDEV force-pushed the fix-bannerObserver branch from 046c1e0 to 96ecd96 Compare April 19, 2021 16:38

vercel bot deployed to Preview April 19, 2021 16:38 View deployment

Fix Banner Observer

2b466bb

PedroFonsecaDEV force-pushed the fix-bannerObserver branch from 96ecd96 to 2b466bb Compare April 19, 2021 16:40

vercel bot deployed to Preview April 19, 2021 16:40 View deployment

PedroFonsecaDEV merged commit e687a0e into Seneca-CDOT:master Apr 19, 2021