Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of 2171 signup flow styles #2190

Merged
merged 10 commits into from
Apr 20, 2021
Merged

Fix part of 2171 signup flow styles #2190

merged 10 commits into from
Apr 20, 2021

Conversation

Meneguini
Copy link
Contributor

Issue This PR Addresses

Part of #2171

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR is fixing the most urgent problems related to the SignUp page styles.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@Meneguini
Copy link
Contributor Author

@humphd @PedroFonsecaDEV @DukeManh

@humphd
Copy link
Contributor

humphd commented Apr 20, 2021

The first screen looks way better (login button has correct margins). However, I can't test the rest. @chrispinkney, can you delete me from Firebase?

Screen Shot 2021-04-20 at 4 49 49 PM

@humphd
Copy link
Contributor

humphd commented Apr 20, 2021

Screen Shot 2021-04-20 at 4 55 00 PM

Screen Shot 2021-04-20 at 4 55 08 PM

Screen Shot 2021-04-20 at 4 55 27 PM

Screen Shot 2021-04-20 at 4 55 40 PM

Screen Shot 2021-04-20 at 4 55 54 PM

Screen Shot 2021-04-20 at 4 56 06 PM

Screen Shot 2021-04-20 at 4 56 13 PM

Screen Shot 2021-04-20 at 4 56 18 PM

Screen Shot 2021-04-20 at 4 56 23 PM

@chrispinkney
Copy link
Contributor

image

😄

@PedroFonsecaDEV PedroFonsecaDEV merged commit 1a54ec1 into Seneca-CDOT:master Apr 20, 2021
@humphd humphd mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@HyperTHD HyperTHD HyperTHD approved these changes

@PedroFonsecaDEV PedroFonsecaDEV PedroFonsecaDEV approved these changes

@DukeManh DukeManh Awaiting requested review from DukeManh

Assignees

@Meneguini Meneguini

Labels
area: front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Meneguini @humphd @chrispinkney @HyperTHD @PedroFonsecaDEV