Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes # 2155: Improved postInfo grid size to fit bigger names on mobile #2192

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Fixes # 2155: Improved postInfo grid size to fit bigger names on mobile #2192

merged 3 commits into from
Apr 20, 2021

Conversation

Meneguini
Copy link
Contributor

Issue This PR Addresses

This PR fixes #2155

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR changes the grid distribution to fit better the author.
It also changed the margin of the AdminButtons to fit better when visible.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Before:
posttitle

After:
authorMobile

authorMobileAndButtons

@PedroFonsecaDEV PedroFonsecaDEV added this to the 2.0 Release milestone Apr 20, 2021
@Meneguini
Copy link
Contributor Author

@chrispinkney @PedroFonsecaDEV @yuanLeeMidori @DukeManh @humphd

PedroFonsecaDEV
PedroFonsecaDEV approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

humphd
humphd approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@PedroFonsecaDEV PedroFonsecaDEV merged commit 512b013 into Seneca-CDOT:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@PedroFonsecaDEV PedroFonsecaDEV PedroFonsecaDEV approved these changes

@yuanLeeMidori yuanLeeMidori Awaiting requested review from yuanLeeMidori

@DukeManh DukeManh Awaiting requested review from DukeManh

Assignees

@Meneguini Meneguini

Labels
area: front-end
Projects
None yet
Milestone
2.0 Release
Development

Successfully merging this pull request may close these issues.

Improve postInfo grid size to fit bigger names on mobile
3 participants
@Meneguini @humphd @PedroFonsecaDEV