Initial work on moving to pnpm from npm #2213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
added
developer experience
|
I've filed a bug upstream on the pnpm GitHub Action, which is failing. |
|
I fixed one issue (most of CI passing now), but hit a new one, where passing args to |
|
I think this is working now, but the e2e tests are failing because of a random installation failure in one microservice for the mock elasticsearch client. I'm going to wait and try again tomorrow to see if it fixes itself. |
|
I'm going to close this, and consider trying Rush instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been experimenting with pnpm for improving our package installation speed/size requirements, and it's really very good. I don't think we can merge this yet, since it doesn't work with Dependabot yet, though it is likely to be added at some point.
The major benefit of pnpm is that it will install a dependency only once, and if multiple packages (e.g., sub-projects like the microservices) use the same package, you only have to install it once. I've found that this is much, much faster, and also requires less disk space (~700M vs. 1.8G).
I wouldn't recommend running
pnpm installin the same tree where you have already runnpm install, but rather to do it in a clean fork if you want to test it. To get rid ofnode_modulesrecursively see: https://css-tricks.com/how-to-delete-all-node_modules-directories-from-your-computer/