All the Elastic APM code from our docker/compose files, envs, logging, Satellite, docs, etc., is cleaned.

[aserputov]

Fixes : #2498

Type of Change

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[gitpod-io]

[humphd]

Can you remove

telescope/docker/production.yml

Line 211 in 667b0d8

# TODO: Kibana + APM, see https://github.com/Seneca-CDOT/telescope/blob/372a6076540351cd54d85478521bcfbe8edefc87/src/api/production.yml

,

telescope/src/api/readme.md

Line 67 in e9d694a

- [Logz: ELK stack on Docker](https://logz.io/blog/elk-stack-on-docker/)

as well?

[humphd]

You're failing Prettier:

Checking formatting...
[warn] docker/production.yml
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

Please set up your environment properly so it auto-formats your code in your editor and when you commit.

[AmasiaNalbandian]

@aserputov we got a conflict!!! :) Let me know if you need help.

[humphd]

No to this:

Please squash and rebase, see https://github.com/Seneca-CDOT/telescope/blob/master/docs/git-workflow.md#squashing-commits

[humphd]

You lost your changes with this rebase. Please bring back your previous branch changes.

[humphd]

You only need 1 of the 3 commits:

$ git checkout -B issue-2498 fcf1e5758e057326ec220b3fd9c364971cba9089
$ git push origin issue-2498 -f

[aserputov]

Why did do we use this commit "fcf1e5758e057326ec220b3fd9c364971cba9089" ?

[humphd]

The other 2 are not really part of this fix.

[humphd]

Excellent

[AmasiaNalbandian]

Were there not more files here before? Can you confirm this was all? @aserputov

[aserputov]

@AmasiaNalbandian, yes, you are right. There were more files before, but to clean pnpm-lock.yaml I will need to create a pull request to Satellite.

[aserputov]

@AmasiaNalbandian can you please review this one ?

[TueeNguyen]

Nit: maybe we can change the title to 'Cleaning All the Elastic APM...'