Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All the Elastic APM code from our docker/compose files, envs, logging, Satellite, docs, etc., is cleaned. #2720

Merged
merged 1 commit into from
Jan 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ services:
- JWT_ISSUER
- JWT_AUDIENCE
- SECRET
# TODO - add APM monitoring support for Satellite
# - ELASTIC_APM_SERVER_URL
# - ELASTIC_APM_SERVICE_NAME
depends_on:
- traefik
labels:
Expand Down
2 changes: 0 additions & 2 deletions docker/production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,5 @@ services:
depends_on:
- nginx

# TODO: Kibana + APM, see https://github.com/Seneca-CDOT/telescope/blob/372a6076540351cd54d85478521bcfbe8edefc87/src/api/production.yml

volumes:
rotate:
1 change: 0 additions & 1 deletion src/api/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,4 @@ pnpm services:stop
## References

- [Digital Ocean: Using traefik v2 as a reverse proxy for Docker](https://www.digitalocean.com/community/tutorials/how-to-use-traefik-v2-as-a-reverse-proxy-for-docker-containers-on-ubuntu-20-04)
- [Logz: ELK stack on Docker](https://logz.io/blog/elk-stack-on-docker/)
- [Elastic: Running Elastic Search on Docker](https://www.elastic.co/guide/en/elastic-stack-get-started/master/get-started-docker.html)