Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for mobile deployment #2954

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

Kevan-Y
Copy link
Contributor

@Kevan-Y Kevan-Y commented Feb 16, 2022

Issue This PR Addresses

Fixes: #2732

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

For testing CI purposes I'm also set up to publish on PR creation, but I think it's better to only publish once we push to master

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@Kevan-Y Kevan-Y added area: CI/CD Continuous integration / Continuous delivery area: React Native labels Feb 16, 2022
@Kevan-Y Kevan-Y self-assigned this Feb 16, 2022
@gitpod-io
Copy link

gitpod-io bot commented Feb 16, 2022

@humphd
Copy link
Contributor

humphd commented Feb 16, 2022

I don't know why it says a user is required:

Run cd src/mobile
  cd src/mobile
  expo publish --non-interactive
  shell: /usr/bin/bash -e {0}
[[2](https://github.com/Seneca-CDOT/telescope/pull/2954/checks#step:7:2)0:00:0[4](https://github.com/Seneca-CDOT/telescope/pull/2954/checks#step:7:4)] An Expo user account is required to proceed.
[20:00:04] Not logged in. Use `expo login -u username -p password` to log in.
Error: Process completed with exit code 1.

I tried deleting the existing token and made a new one, in case that matters.

@Kevan-Y
Copy link
Contributor Author

Kevan-Y commented Feb 17, 2022

I don't know why it says a user is required:

Run cd src/mobile
  cd src/mobile
  expo publish --non-interactive
  shell: /usr/bin/bash -e {0}
[[2](https://github.com/Seneca-CDOT/telescope/pull/2954/checks#step:7:2)0:00:0[4](https://github.com/Seneca-CDOT/telescope/pull/2954/checks#step:7:4)] An Expo user account is required to proceed.
[20:00:04] Not logged in. Use `expo login -u username -p password` to log in.
Error: Process completed with exit code 1.

I tried deleting the existing token and made a new one, in case that matters.

I'm looking into it, not sure why it's not working. It should technically base on the docs.

@humphd
Copy link
Contributor

humphd commented Feb 17, 2022

Is it somehow not happy because my expo account and this repo aren't for the same user?

@Kevan-Y
Copy link
Contributor Author

Kevan-Y commented Feb 17, 2022

this repo aren't for the same user?

Not sure. I'm doing some testing in my other side project to see.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still doesn't work. I'd file an issue with them, or see if you can ask for advice. It has to be the org vs. username on the token.

@nguyenhung15913
Copy link
Contributor

@humphd @Kevan-Y In my case I logged in with my expo account: expo login-u "username" -p "password". But I got an error. I have been also stuck with this one, so I could not create a PR for React Native Homepage
image

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things and we can land this.

.github/workflows/mobile-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/mobile-deploy.yml Show resolved Hide resolved
.github/workflows/mobile-deploy.yml Show resolved Hide resolved
@humphd humphd requested a review from menghif February 18, 2022 17:18
@TueeNguyen TueeNguyen merged commit f2cbee1 into Seneca-CDOT:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Continuous integration / Continuous delivery area: React Native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research how to ship React Native App to Android and iOS devices
5 participants