Search bar added to Navbar instead of participants #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ODAVING
requested review from
jerryshueh,
cagomezr,
lucacataldo,
dbeigi,
eekbatani,
MusaBajwa and
agarcia-caicedo
ODAVING
force-pushed
the
issue242
branch
2 times, most recently
from
de9df0e
to
06185b7
Compare
ODAVING
changed the title
lucacataldo
suggested changes
Nov 21, 2019
There was a problem hiding this comment.
Look really good, well done @ODAVING! Small nit-picky thing just before we merge. If you think the Inconsolata font is absolutely necessary, let me know and we can still merge. I just want to make sure we need it before we commit forever lol. Other than that, looks good to me.
src/frontend/style/main.css
Outdated
| @@ -1,3 +1,6 @@ | |||
| /* Font Used for Search Icon */ | |||
| @import url('https://fonts.googleapis.com/css?family=Inconsolata:700'); | |||
There was a problem hiding this comment.
Maybe keep font dependencies to a minimum? Not only for a more consistent design but also to avoid loading a bunch (although this one is only ~60KB, but it adds up).
There was a problem hiding this comment.
changed it to the main font we use in HTML.
eslint fix changes removed ids for another iteration removed font for consistency
dbeigi
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #242
Added the search button as well as its animation to HTML/CSS. The button will transition between two states, as pictured below
FROM:
TO: