Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login document docker-compose command typo #3786

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

Eakam1007
Copy link
Contributor

@Eakam1007 Eakam1007 commented Jan 13, 2023

Issue This PR Addresses

This PR does not have a related issue

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Fixed docker-compose command typos in the login documentation in the following places:
It should be --build instead of -build

image

Steps to test the PR

  • Run telescope locally
  • Navigate to the documentation by clicking on the ABOUT US button on the home page
  • Under Tools and Technologies, navigate to Login
  • Scroll down to the Running an SSO Identity Provider section
  • Check if the typos have been fixed

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. You don't need to use a "Draft" PR for this, it's good to go. Nice work!

Copy link
Contributor

@sfrunza13 sfrunza13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@Eakam1007 Eakam1007 merged commit c6145ec into Seneca-CDOT:master Jan 13, 2023
@Eakam1007 Eakam1007 deleted the fix-login-doc-typo branch January 13, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants