Adds Docker files as a milestone for issue-4

[Reza-Rajabi]

What is this pull request:
This will add Dockerfile and .dockerignore to the project. So that we can run the project without installing node packages like so:

$ docker-compose up --build

and more importantly, we can ship the Docker image to Kubernetes later on.

[manekenpix]

@Reza-Rajabi is your problem related to issue #48?

[Reza-Rajabi]

@manekenpix Yes it is. Thank you for catching that. I didn't include Redis.

[manekenpix]

@humphd mentioned in #4:

See https://hub.docker.com/_/redis. We can just pull existing images for it.

I tried a docker-compose file that pulls an existing redis image and it works. Feel free to add it to your PR:

version: '3'
services:
  telescope:
    build: .
    depends_on: 
      - redis
    ports:
      - "3000:3000"
    network_mode: host
  redis:
    image: redis:latest
    ports:
      - "6379:6379"

docker-compose up --build for deployment

[Reza-Rajabi]

@manekenpix That's true. Thank you Josue, always helpful. I will add that compose file.

[manekenpix]

I think it looks great, maybe you could include some minimal info in README.md about deployment, and mentioned @jerryshueh's comment on slack about docker and Windows.

[birtony]

@Reza-Rajabi if this PR fixes #4, could you, please, update the title and the description accordingly?

• The title and the description should probably start with Fixes #4
• Fixes is not recognized as a keyword in the title, however, it is convenient for other contributors to see what is the PR about right in the list of all PRs
• Mentioning Fixes in the description will allow us to automatically close the related issue once the PR is merged
• For reference, check Fixes #20: Added basic summarize functionality #66, as an example. When we go to Implement feature to generate summary of the blog post #20 we can see that it May be fixed by #66

[Reza-Rajabi]

@Reza-Rajabi if this PR fixes #4, could you, please, update the title and the description accordingly?

• The title and the description should probably start with Fixes #4
• Fixes is not recognized as a keyword in the title, however, it is convenient for other contributors to see what is the PR about right in the list of all PRs
• Mentioning Fixes in the description will allow us to automatically close the related issue once the PR is merged
• For reference, check Fixes #20: Added basic summarize functionality #66, as an example. When we go to Implement feature to generate summary of the blog post #20 we can see that it May be fixed by #66

@birtony Thank you for catching this. Your point is totally true. The reason I didn't follow this style is that we are not done with this issue, and the commit is actually one milestone of maybe 4 milestones or more. I appreciate your attention. Please keep watching to keep the project clean together.

[Reza-Rajabi]

@manekenpix Do I need to change something in here? I will add the document once it gets merged though.
I need one more review as well and I don't like to assign it to somebody myself, do you have any suggestion for that?

[manekenpix]

I think it'd be better to add the changes to the document here, that way we can have all the initial commits related to docker in this PR and it'll be easier to review the history of the repo in the future. What do you think?

Other than that, ready to get merged 👍

[Reza-Rajabi]

I think it'd be better to add the changes to the document here, that way we can have all the initial commits related to docker in this PR and it'll be easier to review the history of the repo in the future. What do you think?

Other than that, ready to get merged 👍

true. I will make a commit to address the doc change.

[Reza-Rajabi]

@manekenpix I somewhat rebased. So only see the last commit for all changes related to Docker including the CONTRIBUTING.md

[humphd]

@Reza-Rajabi it looks to me like you can just reset your issue-4-docker branch to the 6c1aa4f commit and rebase:

git checkout -B issue-4-docker 6c1aa4f125c5d2b562c8439880ccebac2e18dd2a
git checkout master
git pull upstream master
git checkout issue-4-docker
git rebase master
git push origin issue-4-docker -f

We should make sure people don't merge with master ever, only rebase.

[Reza-Rajabi]

@humphd @manekenpix My apologies! I tried to clean that mess and now the pull request got closed. So do I need to reopen this pull request or I need to make a new pull request?

[manekenpix]

@Reza-Rajabi you can just reopen it. No worries 👍

[Reza-Rajabi]

@manekenpix I will add the doc changes after these gets merged. I don't want to risk on rebase again.

[humphd]

These should both work with our .env, and override via environment variables, but we should confirm, since we expect to be able to set them via .env

[humphd]

@Reza-Rajabi it looks like this PR was made against the wrong branch, so I've merged it, but not into master. Should it have been against master? If so I'll merge it there.

[humphd]

Opened #113 so we can fix this. Please comment there.