Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ESLint to pretest, and moving Jest to test #69

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

@UltimaBGD
Copy link
Contributor

UltimaBGD commented Nov 7, 2019

As referenced in #67, this will allow both ESLint and Jest to run when the npm test command is run. Right now ESLint will run first and give feed back on errors, before running Jest. This order could be changed later but also is most likely for the best right now considering Jest currently needs to be exited with CTRL+C.

@Reza-Rajabi Reza-Rajabi added this to In progress/Review in Main Nov 7, 2019
@manekenpix manekenpix self-requested a review Nov 7, 2019
Copy link
Collaborator

manekenpix left a comment

Just tested it. Works perfectly

Screenshot_20191107_103218

@MusaBajwa MusaBajwa merged commit 4c7b7de into master Nov 7, 2019
Main automation moved this from In progress/Review to Done Nov 7, 2019
@MusaBajwa MusaBajwa deleted the pretest branch Nov 7, 2019
@Reza-Rajabi Reza-Rajabi added the on-board label Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Main
Done
4 participants
You can’t perform that action at this time.