Adding ESLint to pretest, and moving Jest to test #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manekenpix
approved these changes
Nov 7, 2019
MusaBajwa
approved these changes
Nov 7, 2019
DukeManh
pushed a commit
to DukeManh/telescope
that referenced
this pull request
Mar 7, 2022
…ock-7.x fix(deps): update dependency ioredis-mock to v7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in #67, this will allow both ESLint and Jest to run when the
npm testcommand is run. Right now ESLint will run first and give feed back on errors, before running Jest. This order could be changed later but also is most likely for the best right now considering Jest currently needs to be exited with CTRL+C.